Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken language selector style after update to v1.11.0 #384

Open
McPringle opened this issue Oct 2, 2022 · 4 comments
Open

Broken language selector style after update to v1.11.0 #384

McPringle opened this issue Oct 2, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@McPringle
Copy link

McPringle commented Oct 2, 2022

Describe the bug
After my update from v1.10.0 to v1.11.0 the language selector style is broken. It does not show a dropdown as expected. It is now shown as a (misaligned) list.

To Reproduce
Steps to reproduce the behavior:

  1. Update theme to v1.11.0
  2. Run hugo server

Expected behavior
The language selector should still be shown as a dropdown.

Screenshots
Screenshot with theme version 1.10.0:
image
Screenshot with theme version 1.11.0:
image

Desktop (please complete the following information):

  • OS: Windows
  • Browser: Chrome, Firefox
  • Version of the Theme: 1.11.0
  • Version of Hugo: v0.104.2-84cbe724983b4b6153fd39aae0888cbb89a56cda windows/amd64 BuildDate=2022-09-29T10:31:09Z

Smartphone (please complete the following information):
No test from myself on a smartphone.

Additional context
I only added some CSS for the profile picture:

img.sidebar__introduction-profileimage {
    filter: grayscale(100%);
}

img.sidebar__introduction-profileimage:hover {
    filter: grayscale(0);
}

That should not have any effect to the language selector.

@McPringle McPringle added the bug Something isn't working label Oct 2, 2022
@lxndrblz
Copy link
Owner

@McPringle Thanks for reporting this issue. I am having trouble reproducing it on any of my systems. Do you have a link which shows the issue in action?

@McPringle
Copy link
Author

The repository is private, I'll prepare a minimal example for you soon.

@McPringle
Copy link
Author

I made the repository of my website public. There is nothing to hide in there. :-)

The repository URL is: https://github.com/McPringle/mcpringle.github.io
The website address (GitHub Pages) is: https://fihlon.swiss/en/

I guess it has to do with changes in navbar.html. There was a refactoring of the language selector on February 5th and 6th this year, right between the releases of v1.10.0 and v1.11.0.

@lxndrblz
Copy link
Owner

@McPringle Is that issue still current? Otherwise I would go ahead and close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants