From eda91d12631593aa27fbe372682a175b2c3b4914 Mon Sep 17 00:00:00 2001 From: Celia La Date: Thu, 9 May 2024 16:27:45 -0700 Subject: [PATCH] codeowners: add upgrade-prs team to pkg/upgrade Epic: None Release note: None Release justification: non-production change (updating codeowners). --- .github/CODEOWNERS | 4 ++-- TEAMS.yaml | 3 +++ pkg/cmd/roachtest/registry/owners.go | 1 + pkg/cmd/roachtest/tests/acceptance.go | 1 + pkg/internal/team/TEAMS.yaml | 3 +++ 5 files changed, 10 insertions(+), 2 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 1fa644eb01d7..ea16ceccbb42 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -379,7 +379,7 @@ /pkg/ccl/jwtauthccl/ @cockroachdb/cloud-identity #!/pkg/ccl/kvccl/ @cockroachdb/kv-noreview /pkg/ccl/kvccl/kvtenantccl/ @cockroachdb/server-prs -#!/pkg/ccl/upgradeccl/ @cockroachdb/release-eng +#!/pkg/ccl/upgradeccl/ @cockroachdb/release-eng-prs @cockroachdb/upgrade-prs #!/pkg/ccl/logictestccl/ @cockroachdb/sql-queries-noreview #!/pkg/ccl/sqlitelogictestccl/ @cockroachdb/sql-queries-noreview /pkg/ccl/multiregionccl/ @cockroachdb/sql-foundations @@ -515,7 +515,7 @@ /pkg/keysbase/ @cockroachdb/kv-prs # Don't ping KV on updates to reserved descriptor IDs and such. #!/pkg/keys/constants.go @cockroachdb/kv-prs-noreview -/pkg/upgrade/ @cockroachdb/release-eng +/pkg/upgrade/ @cockroachdb/release-eng-prs @cockroachdb/upgrade-prs /pkg/keyvisualizer/ @cockroachdb/obs-prs /pkg/multitenant/ @cockroachdb/server-prs /pkg/release/ @cockroachdb/dev-inf diff --git a/TEAMS.yaml b/TEAMS.yaml index ba4d1aa7fbc8..1f0998cc758c 100644 --- a/TEAMS.yaml +++ b/TEAMS.yaml @@ -105,5 +105,8 @@ cockroachdb/migrations: label: T-migrations triage_column_id: 18330909 cockroachdb/release-eng: + aliases: + cockroachdb/release-eng-prs: other + cockroachdb/upgrade-prs: other label: T-release triage_column_id: 9149730 diff --git a/pkg/cmd/roachtest/registry/owners.go b/pkg/cmd/roachtest/registry/owners.go index 48e60ad0e943..096511f3c8f3 100644 --- a/pkg/cmd/roachtest/registry/owners.go +++ b/pkg/cmd/roachtest/registry/owners.go @@ -33,6 +33,7 @@ const ( OwnerServer Owner = `server` // not currently staffed OwnerSQLFoundations Owner = `sql-foundations` OwnerMigrations Owner = `migrations` + OwnerReleaseEng Owner = `release-eng` OwnerSQLQueries Owner = `sql-queries` OwnerStorage Owner = `storage` OwnerTestEng Owner = `test-eng` diff --git a/pkg/cmd/roachtest/tests/acceptance.go b/pkg/cmd/roachtest/tests/acceptance.go index f2622262c60c..35095fa8aec4 100644 --- a/pkg/cmd/roachtest/tests/acceptance.go +++ b/pkg/cmd/roachtest/tests/acceptance.go @@ -36,6 +36,7 @@ func registerAcceptance(r registry.Registry) { nativeLibs []string incompatibleClouds []string // Already assumes AWS is incompatible. }{ + registry.OwnerReleaseEng: {}, registry.OwnerKV: { {name: "decommission-self", fn: runDecommissionSelf}, {name: "event-log", fn: runEventLog}, diff --git a/pkg/internal/team/TEAMS.yaml b/pkg/internal/team/TEAMS.yaml index ba4d1aa7fbc8..1f0998cc758c 100644 --- a/pkg/internal/team/TEAMS.yaml +++ b/pkg/internal/team/TEAMS.yaml @@ -105,5 +105,8 @@ cockroachdb/migrations: label: T-migrations triage_column_id: 18330909 cockroachdb/release-eng: + aliases: + cockroachdb/release-eng-prs: other + cockroachdb/upgrade-prs: other label: T-release triage_column_id: 9149730