From b1cdf270ec0982c0daca77a3e981698fea610b1f Mon Sep 17 00:00:00 2001 From: Yahor Yuzefovich Date: Wed, 1 May 2024 10:16:38 -0700 Subject: [PATCH 1/4] github: adjust stale workflow This commit adjusts the stale workflow so that it only closes stale test failures and sentry issues. Previously, it would close all issues with no activity in the last 18 months (modulo some exempted labels), but I don't think it's helpful to close issues filed by humans in this way - we might still want to track a particular bug or a feature in order to gauge the urgency. Closing stale (no activity in 12 months) test failures (as defined by having `C-test-failure` label) and sentry issues seems like a good idea though. This commit also removes a few fields that are related to stale PRs since we don't do anything for them (because we use very large "inactivity" window). Release note: None --- .github/workflows/stale.yml | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml index 05917aa1bc9f..689e4f295530 100644 --- a/.github/workflows/stale.yml +++ b/.github/workflows/stale.yml @@ -1,4 +1,4 @@ -name: Mark stale issues and pull requests +name: Close stale test failures and sentry issues on: schedule: @@ -18,17 +18,14 @@ jobs: repo-token: ${{ secrets.GITHUB_TOKEN }} stale-issue-message: | We have marked this issue as stale because it has been inactive for - 18 months. If this issue is still relevant, removing the stale label + 12 months. If this issue is still relevant, removing the stale label or adding a comment will keep it active. Otherwise, we'll close it in - 10 days to keep the issue queue tidy. Thank you for your contribution - to CockroachDB! - stale-pr-message: 'Stale pull request message' + 10 days to keep the issue queue tidy. stale-issue-label: 'no-issue-activity' - stale-pr-label: 'no-pr-activity' close-issue-label: 'X-stale' - close-pr-label: 'X-stale' # Disable this for PR's, by setting a very high bar days-before-pr-stale: 99999 - days-before-issue-stale: 540 + days-before-issue-stale: 366 days-before-close: 10 + any-of-issue-labels: 'C-test-failure,O-sentry' exempt-issue-labels: 'release-blocker,X-anchored-telemetry,X-nostale' From 8576f93b7a82674ed3b06e144a1ecd8360cd71d0 Mon Sep 17 00:00:00 2001 From: Ricky Stewart Date: Wed, 1 May 2024 12:45:11 -0500 Subject: [PATCH 2/4] streamclient: allow running on remote execution I don't know how long this has worked, but it works now. Epic: CRDB-8308 Release note: None --- pkg/ccl/streamingccl/streamclient/BUILD.bazel | 1 - 1 file changed, 1 deletion(-) diff --git a/pkg/ccl/streamingccl/streamclient/BUILD.bazel b/pkg/ccl/streamingccl/streamclient/BUILD.bazel index 1a59eabde0de..430936593a59 100644 --- a/pkg/ccl/streamingccl/streamclient/BUILD.bazel +++ b/pkg/ccl/streamingccl/streamclient/BUILD.bazel @@ -57,7 +57,6 @@ go_test( "span_config_stream_client_test.go", ], embed = [":streamclient"], - tags = ["no-remote-exec"], deps = [ "//pkg/base", "//pkg/ccl", From 2da336111edd99be2ff65c0b84f80899191e29ff Mon Sep 17 00:00:00 2001 From: Xin Hao Zhang Date: Tue, 30 Apr 2024 15:57:38 -0400 Subject: [PATCH 3/4] roachtest: set 23.1.8 as MinSupportedVersion for sql-stats/mixed-version There is a bug in the sql stats api prior to 23.1.8, where passing a requested start time of 0 or nil results in a nil pointer dereference. Setting this min supported version also resolves some mixed version authentication limitaitons. Epic: none Fixes: #123278 Release note: None --- pkg/cmd/roachtest/tests/mixed_version_sql_stats.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/cmd/roachtest/tests/mixed_version_sql_stats.go b/pkg/cmd/roachtest/tests/mixed_version_sql_stats.go index 3854819281f2..a0f7397ed11e 100644 --- a/pkg/cmd/roachtest/tests/mixed_version_sql_stats.go +++ b/pkg/cmd/roachtest/tests/mixed_version_sql_stats.go @@ -54,7 +54,8 @@ func registerSqlStatsMixedVersion(r registry.Registry) { func runSQLStatsMixedVersion(ctx context.Context, t test.Test, c cluster.Cluster) { roachNodes := c.Range(1, c.Spec().NodeCount-1) workloadNode := c.Node(c.Spec().NodeCount) - mvt := mixedversion.NewTest(ctx, t, t.L(), c, roachNodes) + mvt := mixedversion.NewTest(ctx, t, t.L(), c, + roachNodes, mixedversion.MinimumSupportedVersion("v23.1.8")) flushInterval := 2 * time.Minute initWorkload := roachtestutil.NewCommand("./cockroach workload init tpcc"). @@ -163,7 +164,7 @@ func getCombinedStatementStatsURL( ) string { searchParams := fmt.Sprintf("?fetch_mode.stats_type=%d&start=%d&end=%d&limit=10", statsType, requestedRange[0].Unix(), requestedRange[1].Unix()) - return `http://` + adminUIAddr + `/_status/combinedstmts` + searchParams + return `https://` + adminUIAddr + `/_status/combinedstmts` + searchParams } // timeRange is a pair of time.Time values. From 73909593eff06e37cc4f0493ef2f5618ddd2d82b Mon Sep 17 00:00:00 2001 From: Ricky Stewart Date: Wed, 1 May 2024 14:03:51 -0500 Subject: [PATCH 4/4] roachtest: move `generate-fixtures` roachtest to `test-eng` ownership Epic: none Release note: None --- pkg/cmd/roachtest/tests/fixtures.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/cmd/roachtest/tests/fixtures.go b/pkg/cmd/roachtest/tests/fixtures.go index 105dbf1aed52..9d739b3eea4b 100644 --- a/pkg/cmd/roachtest/tests/fixtures.go +++ b/pkg/cmd/roachtest/tests/fixtures.go @@ -67,7 +67,7 @@ func registerFixtures(r registry.Registry) { Timeout: 30 * time.Minute, CompatibleClouds: registry.Clouds(spec.GCE, spec.Local), Suites: registry.Suites(registry.Fixtures), - Owner: registry.OwnerDevInf, + Owner: registry.OwnerTestEng, Cluster: r.MakeClusterSpec(4), Run: runFixtures, })