Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zone diffs only include the most recent diff since tagging the repository #39

Open
nkinkade opened this issue Aug 7, 2019 · 0 comments

Comments

@nkinkade
Copy link
Contributor

nkinkade commented Aug 7, 2019

This may not be the right place for this issue, and could possibly be a better fit in m-lab/mlabops for the deploy_zones.yaml Ansible playbook. But I'm putting it here for now. The zone diff that site info produces and publishes only contains the diff since the repository was last tagged. If the repository was tagged multiple times since the last time the measurement-lab.org zone was deployed, then the diff will not reflect the actual difference between the published zone file and the currently generated zone file, but only the most recent changes.

This leads me to believe that the diff is not all that useful, unless we somehow make a commitment to always deploy the DNS zones after every tagging of the siteinfo repository. Otherwise, a better approach might be to have the Ansible playbook diff the currently published zone with the most recent copy in published by siteinfo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants