Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Input.Search storybook stories #201

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ZoeAstra
Copy link
Contributor

Instructions

  1. PR target branch should be against main
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

Adds storybook stories for the Input.Search component, as there were none before.

Testing Plan

  • Was this tested locally? If not, explain why.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@ZoeAstra ZoeAstra self-assigned this Apr 11, 2024
@ZoeAstra ZoeAstra changed the title chore(search.stories.tsx): add Input.Search storybook stories chore: add Input.Search storybook stories Apr 11, 2024
@ZoeAstra ZoeAstra requested a review from jared-dickman April 11, 2024 20:42
@ZoeAstra
Copy link
Contributor Author

Closing and reopening to see if this fixes the semantic title check.

@ZoeAstra ZoeAstra closed this Apr 11, 2024
@ZoeAstra ZoeAstra reopened this Apr 11, 2024
Comment on lines +8 to +16
args: {
placeholder: 'Input.Search Placeholder',
enterButton: undefined,
loading: false,
onSearch: e => {
console.log('Search triggered: ' + String(e))
},
},
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit Any idea of how to provide defaults for the props table:
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argTypes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants