Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert ad_completed and ad_skipped to Strings #28

Open
meowlie opened this issue Apr 11, 2023 · 0 comments
Open

Convert ad_completed and ad_skipped to Strings #28

meowlie opened this issue Apr 11, 2023 · 0 comments

Comments

@meowlie
Copy link

meowlie commented Apr 11, 2023

Should these lines end with an additional .toStr()

https://github.com/mParticle/mparticle-roku-sdk/blob/master/mParticleCore.brs#L1793-L1794

Because the values are stored as booleans, and these will not get sent due to not being strings:

https://github.com/mParticle/mparticle-roku-sdk/blob/master/mParticleCore.brs#L1850
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@meowlie