Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application version fields have been replaced with OS version #30

Open
g4r37h opened this issue Jun 22, 2023 · 0 comments
Open

Application version fields have been replaced with OS version #30

g4r37h opened this issue Jun 22, 2023 · 0 comments

Comments

@g4r37h
Copy link

g4r37h commented Jun 22, 2023

I can see that in a few recent commits, you guys have made changes to move away from deprecated API calls. However, in doing so, you've actually replaced calls that previously returned the application version with calls that return the OS version. This affects av, dosv and vr event fields.

For instance:

av: appInfo.GetVersion()

Has been replaced with:

osVersion = deviceInfo.GetOSVersion()
av: osVersion["major"] + "." + osVersion["minor"]

https://developer.roku.com/en-gb/docs/references/brightscript/interfaces/ifappinfo.md#getversion-as-string
https://developer.roku.com/en-gb/docs/references/brightscript/interfaces/ifdeviceinfo.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant