Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generatejson.py number of parser arguments incorrect? #101

Closed
fortiko opened this issue Dec 1, 2021 · 3 comments
Closed

generatejson.py number of parser arguments incorrect? #101

fortiko opened this issue Dec 1, 2021 · 3 comments

Comments

@fortiko
Copy link

fortiko commented Dec 1, 2021

Hello! Sorry if I missed something, but on line 237 of generatejson.py it says

parser.add_argument('--item', default=None, action='append', nargs=6,

but then the code proceeds to require 7 arguments:

item-name='A name'
item-path='A path'
item-stage='A stage'
item-type='A type'
item-url='A url'
script-do-not-wait='A boolean'
pkg-skip-if='A string'

which for me leads to ValueError("length of metavar tuple does not match nargs").

If I updated nargs=7, the code works as expected and generates bootstrap.json in the output directory.

Should that be fixed or am I missing something here?

@erikng
Copy link
Member

erikng commented Dec 2, 2021

It could be a bug. I've merged some PRs lately that I personally haven't tested and trusted the author. If you have fixed it, please PR it and I'll merge.

@andrewzirkel
Copy link

I have it fixed in 100 so you can reference that or merge that piece.

@erikng
Copy link
Member

erikng commented Dec 2, 2021

I fixed it. Thanks for the note.

@erikng erikng closed this as completed Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants