Reimplementation of Remotes module #26
Conversation
scunz
force-pushed
the
ngf/remotes-module
branch
from
273c785 to
221e0ec
Compare
|
You should now be able to clone "just" As soon as you give me a go, I'll rename the |
|
Yeah, just do it whenever you like. I have only small pending changes. Not a problem at all. |
|
Done :) |
antis81
changed the title
antis81
force-pushed
the
ngf/remotes-module
branch
2 times, most recently
from
2f99e28 to
a0cb7a3
Compare
The menu is at the wrong place and about to be moved to the appropriate context (e.g. repo, branch, remote, ...)
…s a mergeable submenu.
The dialog is non-functional yet. It could use the (Options ...) technique from the clone dialog to hide the "advanced options".
…> all remotes" Also fixes a compile error due to a double closing bracket. Caution: This currently *only* works within a repository context (static cast to RM::Repo)! If used in other contexts, MGV might crash or not behave like expected!
This allows us to define different entry points for the fetch/push actions and assign an appropriate action context later.
The menu structure is also meant to be integrated in the reference and history view later.
This is meant to limit the fetch context and thus requires a single "Remote" or "remote branch" context.
Sets the parent to the main window.
antis81
force-pushed
the
ngf/remotes-module
branch
from
7573564 to
04cff93
Compare
|
FYI: Here's a screenshot of what the new "Remotes" dialog now looks like: |
|
Could you drop the "manage the" in the caption? It's a bit confusing. |
|
Yes, no problem. This is a relict 😄. |
Extended options need some cleanup to appear correctly aligned.
|
Can we get this into development, so that I'd be able to rebase the whole |
|
Sure, I'll push the merge button :). |
Restructuring the Remotes module
|
Note: The "Repository" menu currently looks a bit puzzled. This is related to some commits sleeping in #36 cleaning this up. Sorry for the inconvenience. 😇 |
|
Could you cherry-pick these onto development before I rebase or is it going to be too complex? |
|
Hm ... actually I don't know. Let me take a look. I'll try and cherry pick those. |
|
Sorry, once again a typical PEBKAC problem 👨 🪲. I forgot about, how the menu looked before. This PR just adds the right entries related to the "Remotes" module - appart from the "clone" entry - which still resides in the "Repository" module. See by yourself:
The changes merge completely fine into the "current" main menu. The former "Remotes" menu became a submenu of "Repository" and was renamed to "Active Repository". The "Repository->New" entry should be at the top. Uhm, like this: I have to recheck, where I've changed it. It's has to be either part of #36 or in my private branch. If it is easy to cherry-pick, I'll do that. Anyways, this doesn't hold us back from rebasing or cause any other trouble - this is all I wanted to say 😄. |
|
DONE! Git rebase is simply great 👍!!! FYI: I removed the change completely from #36 and transplanted it as a new commit on development. |
|
Somehow I don't get messages for everything. I'm not sure if that's Github's or my mail server's fault, actually - but Github is strange at times. I've actually been rebasing all night long, actually. Rebase is great. I'm trying to clean up my mess in #27 - I've pushed an intermediate version to |
|
Oh, ant btw: I don't really like the Idea of moving the And since we have the concept of a context for all actions, it should be self explaining that the main menu actions actually act on the active repository. |
|
And me again: It's okay for now. We really really really have to take care of the underlying stuff now. So, the priorities are: RepoMan / Activities / Services. We should not start anything new unless these things reach a mature state and everything is properly ported. We've been beating around the bush for quite a while and now it's time to do it right :) |
As always, when I don't get notifications: GitHub didn't even try to connect to my mail server in the related timespan today, even though I'm subscribed to this PR. |
Hm ... I didn't experience such problems up to now. This might however be the fact, that I get less messages ... Or maybe a hungry shark ate the underwater cable 🐟 😄. |
@antis81, this is a copy from the modules-PR. Please go ahead here; the Modules Repo is now fully integrated and I rebased this one so that it ought to be in exactly the same state; just with the new locations.