Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Split diff and files view #4

Open
antis81 opened this issue Mar 12, 2013 · 1 comment
Open

Split diff and files view #4

antis81 opened this issue Mar 12, 2013 · 1 comment

Comments

@antis81
Copy link
Member

antis81 commented Mar 12, 2013

Would be great, if we could split the "file list" and "diff area", being able to select a file entry from the "top" and get the diff area scrolled to that file shown. Commits with 5+ files would become more easy to browse through.

Thinking about that. Would it be cool rendering just the selected file?

I think, we should put this one into MGV V0.2.

@scunz
Copy link
Member

scunz commented Mar 13, 2013

My original intention was to create something like Kompare. But then I realized this will take some time to implement, so i settled with the "RawDiffView" at first. With that came the Idea, that MGV could provide several diff-Views and let the user decide what s/he likes most.

After seeing GitX and realizing the many bugs and inconveniences that RawDiffView has, I did a Quick'n'Dirty implementation of a view that displays the diff-model in a simple sequence. (The SeqView).

This one is based on the look (not the feel) of the GitX diff view. Contrary to GitX it's based on a Graphics-Scene rather than HTML. HTML would have immediately required a dependency on QWebKit.

To also get the feel of GitX, there would be indeed a few things to do:

  • Anchor each file and allow to jump there (codewise)
  • Provide links in the file overview to jump to the anchors
  • Make the files overview collapsible.
  • Tighten the Hunk-View with libHeaven, so that it becomes possible to create Heaven::Actions on the hunk view ("Stage this hunk", "Revert this hunk", "Stage this file" etc.pp)

The first 3 bullets are more or less a technical description of the initial proposal in this Issue. The last bullet is a very advanced topic that will require much work (probably).

Would it be cool rendering just the selected file?

"History View" has no concept of "selected file", because it shows trees :-) So this could only apply to the WorkingTree and Index Views. For those, I'd even suggest: We put a toggle button somewhere. If it's down, show full diff. If it's not down, sync WT/Index-Selection with DiffView (This gives the additional advantage to show diff of a subtree).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants