-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Column default sort order does not override global default #25
Comments
Hey @dhimmel, long time no see! Shoot, thanks for reporting -- it looks currently we handle the initial sort order, but need to add a Column.default_sort_desc property to say what should happen when resorting 😓 |
haha yes! @trangdata told me about R reactable and then we saw you're making a python client.
I figured |
ah nice! Sorry, I should have been clearer that it's a bug in reactable-py :/, but should be fixed in the v0.1.3 release just now! |
Cool thanks for #26. The following code using a reactable.Reactable(
pl_penguins,
default_col_def=reactable.Column(default_sort_order="desc"),
columns=[reactable.Column(id="species", default_sort_order="asc")],
) I don't think the global reactable.Reactable(
pl_penguins,
default_sort_order="desc",
columns=[reactable.Column(id="species", default_sort_order="asc")],
) Anyways, I'm all good since the |
shoot :/, the table sorting default behavior should be fixed now in https://github.com/machow/reactable-py/releases/tag/v0.1.4 |
Confirming that both examples now work as expected. Thanks! |
Amazing package! Extremely powerful and functional for its star count. I sense a bright future here.
Similar to this example but without setting
default_sorted
:The first time I click on the
species
header, that columns sorts descending (along with all other columns). The expected behavior is forspecies
to first sort ascending because the Column setsdefault_sort_order="asc"
.Seems to work at https://glin.github.io/reactable/articles/examples.html#default-sort-order
The text was updated successfully, but these errors were encountered: