Community move to maintained fork or gem

[Schwad]

EDIT 2017-07-24: We have moved community maintenance over to the trix-rails gem

---

Hello! 👋

We rely on the trix gem at my place of work and I also personally rely on it for a few projects. I currently have an outstanding issue in my bugtracker to 'watch' the trix gem for the day that we no longer have to point our main application to a fork.

We have been waiting on an update for Rails 5.2 support since april. The current solution for myself, @Aberen and others is to use @DRBragg 's fork.

Another bugfix very kindly submitted by @kylefox in March hasn't been merged even though it's passing, so the current solution is to point to @bcoia 's fork. @markmercedes and @nrosella asked in April if this gem is maintained with no response as of yet.

I think instead of pinging the (very likely overloaded with plenty of work! 😄 ) maintainer we should use this issue to document our decision to either agree a 'maintained' fork or a new gem. ( trixx? trix-ruby? trix-fork?)

[Schwad]

I've reserved trix-community. https://rubygems.org/gems/trix-community

[DRBragg]

I have a modified version of Trix that I use at work up as a gem. I can spin up a new gem for trix-core if we really think this one is dead.

[DRBragg]

I emailed the maintainer a month or so ago about helping out but didn't here back. I see he's been active but, I agree, probably busy.

[nrosella]

More than happy to move to a new, maintained version. I currently have my own fork of Trix in a production app, so would like to see this all sorted.

…

On Wed, 18 Jul 2018 at 13:50, Drew Bragg ***@***.***> wrote: I emailed the maintainer a month or so ago about helping out but didn't here back. I see he's been active but, I agree, probably busy. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#69 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJffRt-HZrwNrAhL1nx3AB8O_768gafyks5uHy8QgaJpZM4VUNbT> .

[DRBragg]

@nroella, I did the same until I had modified it enough to warrant its own gem.

[DRBragg]

@nrosella @Schwad here you go

https://rubygems.org/gems/trix-gem

https://github.com/DRBragg/trix-gem

Happy to bring you guys on as contributors if you're interested.

[kylefox]

I also have a maintained fork that we rely on heavily at Podia. It adds 5.2 support (with specs) and is used in production.

It also allows all HTML options to be passed through to the trix_editor_tag call. This allows you to add things like required=true or data-* attributes to the <trix-editor> tag.

It would be great if the maintained fork not only supported Rails 5.2, but had specs and ☝️ the feature I mentioned above.

I'm happy to add other people as contributors to my fork. You can compare my fork with @maclover7's here: master...kylefox:master

[Schwad]

Thanks all for the input here! :)
Definitely underlining I’ve put this issue up out of respect for the original maintainer as he is probably very busy.

Since I am slightly keen (personally) to point to a gem longer term over a fork, @DRBragg I might look to pointing to your gem while also looking to a PR for some of @kylefox ‘s contributions as well? Just to kind of bring together our combined efforts here.. thanks again for the prompt thoughts everyone much appreciated

[ghost]

We JUST imported this gem into Amazon's build system. Whatever you decide to use, please update this issue so our project can consume that instead. Maybe one of you can reach out to Basecamp and see if they'll own the gem? IIRC the same people who made Trix also made Rails and they may be interested in owning this.

[ghost]

He's also active on Twitter. Another option is for him to add you all as maintainers? https://twitter.com/applerebel

[DRBragg]

@kylefox I added you to the trix-gem repo as a collaborator if you want start incorperating some of those features.

@mullermp you can find the trix-gem here: https://rubygems.org/gems/trix-gem. It is an updated version of this gem with rails 5.2 support. I plan on keeping it updated and hopefully @kylefox will be enhancing it.

You all are welcome to submit PRs here: https://github.com/DRBragg/trix-gem

[kylefox]

Thanks @DRBragg — however it looks like you nuked all the git history?

I'll likely be going forward with my own fork of the gem, trix-rails. Trix is a pretty critical part of Podia, so I'd like to have my own active fork, along with all the git history so I can reverse-engineer more easily when needed 😁

We've also built some stuff that incorporate's ActiveStorage's Direct Upload functionality, which will make drag & drop file uploading Just Work with Trix + Rails. Hoping to clean that up and publish soon.

[nrosella]

I'm going to switch over to @kylefox fork. The current and upcoming features are in line with what I'm looking for, and I like that it's had some kind of battle-testing being part of Podia.

Thanks for all the work guys.

[Schwad]

Okay, so it seems like we have two maintained options going forward for those who visit this issue with questions in the future.

Both maintainers appear willing to accept PR's from outside and maintain the community spirit.

• @DRBragg 's fork trix-gem which keeps the latest trix functionality up to date. It does seem that it has started the git history over from scratch.

• @kylefox 's fork trix-rails. It appears to extend trix functionality into Rails 5 as well. It does introduce a new feature to allow arbitrary options to trix editor tag - afomera@efea9ad .

I think that's a fine approach on both and as someone who relies on trix I'm pleased with the response here. For the time being I will hang on to but not work on trix-community. However, if we reach a point where both of these gems seem to build out really cool, but different, features, I may consider building that gem out to include all those contributions.

I am leaving this issue open for now as a sort of 'documentation' for people who come in the future and also to allow this discussion to continue. Feel free to chip in here! :)

[DRBragg]

Sorry about nuking the git history, I wasn't thinking when I was throwing together the gem and just rolled a clean one. I had an opportunity to to look over @kylefox 's fork and I like it. He added intelligent and useful additions and ensured that they had test coverage. I'll keep the trix-gem up to date, just incase anyone wants the barebones gem, but I'll personally use @kylefox 's fork.

[Schwad]

Thanks for the help and your feedback @DRBragg ! Appreciate your thoughts on this. I feel we have a pretty good consensus between everyone here then. I will also move myself and our company OceansHQ over to trix-rails.

[Schwad]

@kylefox in the spirit of this thread, filed my first PR over on yours. 😄 thanks for the help!

[kylefox]

Thanks for kickstarting this conversation @Schwad 🙂

I am leaving this issue open for now as a sort of 'documentation' for people who come in the future and also to allow this discussion to continue. Feel free to chip in here! :)

I think this is a good idea. It could be a good "sticky" thread for discussion amongst the different forks. Might be worth linking to the various forks in your original post?

I'm also happy to have @maclover7's input, if he decides to join this discussion at some point. Whether that's adding me (and others) as contributors to this repo, retiring this repo entirely, etc.

[Schwad]

Good point @kylefox , updating. :D +1 To all that you've said. I would also invite people in this thread now and visitors to hop over to trix-rails to join the conversation on the PRs and issues.

[Schwad]

Today my company officially moved our Gemfiles to point to trix-rails, great to be on board!