Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More context in homepage #4

Open
LeaVerou opened this issue Jan 24, 2023 · 6 comments
Open

More context in homepage #4

LeaVerou opened this issue Jan 24, 2023 · 6 comments

Comments

@LeaVerou
Copy link
Contributor

The current index page on auth.madata.dev doesn't provide any context for someone visiting it:

image

It should have some sort of heading (e.g. "Madata Authentication Provider"), with a link to documentation, and it should list the backends instead of linking to a JSON file.

@DmitrySharabin
Copy link
Member

Could you please give it another look? I tried to add more context. And styled the page to my taste. Please feel free to change anything you'd like to change.

@LeaVerou
Copy link
Contributor Author

Looks great! However, now the backends need to be hardcoded in the CSS, which is suboptimal. How does it do with backends that do not correspond to a CSS class?

I was just thinking, when we split this to a template repo and a fork, we should have "Madata Authentication Provider" in the template repo and "Madata Official Authentication Provider" only in our fork.

PS: We may not want to do a template repo, as it will be a pain to pull in changes, see https://stackoverflow.com/questions/56577184/github-pull-changes-from-a-template-repository

@DmitrySharabin
Copy link
Member

How does it do with backends that do not correspond to a CSS class?

What if we provide a placeholder icon based on the Madata logo (e.g., with some sort of a badge, like “backend”)? Later, devs can replace it with their own logo and/or redefine only one simple rule in their CSS to reflect the changes. What do you think?

@LeaVerou
Copy link
Contributor Author

How does it do with backends that do not correspond to a CSS class?

What if we provide a placeholder icon based on the Madata logo (e.g., with some sort of a badge, like “backend”)? Later, devs can replace it with their own logo and/or redefine only one simple rule in their CSS to reflect the changes. What do you think?

SGTM. Or maybe a stylized icon based on the first letter of the backend, like some avatars?

@LeaVerou
Copy link
Contributor Author

Though I'm worried this is spending effort on things that are not on the critical path

@DmitrySharabin
Copy link
Member

Are we done with that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants