Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the package name in the installation part. fixes #27 #28

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

Javadyakuza
Copy link
Contributor

@Javadyakuza Javadyakuza commented Sep 26, 2024

Summary

What

Changed the maestro package name to maestro-rust-sdk

Why

Rust analyzer couldn't recognize the the repo as a package with the maestro as the package name.

How

_

p.s. The main package name can alternatively be changed to maestro as well.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Code refactoring (improving code quality without changing its behavior)
  • [] Documentation update (adding or updating documentation related to the project)

Checklist

  • I have read the Contributing Guide
  • My code follows the project's coding style and best practices
  • My code is appropriately commented and includes relevant documentation
  • I have added tests to cover my changes
  • All new and existing tests pass
  • I have updated the documentation, if necessary

Testing

N/A

Additional Information

#N/A

Change the `maestro` to `maestro-rust-sdk` for the rust analyzer  to recognize the package.

p.s. The package name can alternatively be changed for the sake of simplicity.
Fix the package name in the installation part. fixes maestro-org#27
@Javadyakuza Javadyakuza requested a review from a team as a code owner September 26, 2024 00:01
Copy link
Contributor

@Vardominator Vardominator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Javadyakuza Can you please bump the version in Cargo.toml to 1.2.3? After that I'll merge and release!

@Javadyakuza
Copy link
Contributor Author

@Javadyakuza Can you please bump the version in Cargo.toml to 1.2.3? After that I'll merge and release!

done ✔️

@Vardominator Vardominator self-requested a review September 30, 2024 17:19
Copy link
Contributor

@Vardominator Vardominator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@Vardominator Vardominator merged commit 9400a80 into maestro-org:main Sep 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants