New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy action doesn't always fail when it should #687

Open

Jack-Papel opened this issue Sep 7, 2024 · 0 comments

Collaborator

Jack-Papel commented Sep 7, 2024

The action doesn't fail when there is an error with the mafia-server service. But it also doesn't error when the rust build fails.

Making it fails when the rust build fails is relatively easy.

To make sure it fails if the service fails, the action should include a 'check' step to make sure the server was actually built and is running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment