Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWA-3331::System is getting crashed when selecting add to cart in cas… #4318

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
+46 −28
Open

PWA-3331::System is getting crashed when selecting add to cart in cas… #4318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
954b903
PWA-3331::System is getting crashed when selecting add to cart in cas…
glo82145 Aug 27, 2024
047029e
PWA-3331::System is getting crashed when selecting add to cart in cas…
glo82145 Aug 28, 2024
98eea8a
fix issue
glo82145 Oct 21, 2024
bbd3fb3
fix issue
glo82145 Oct 21, 2024
9b49d31
Wrapping FormatMessage Component with <div> so that browser translate…
del15881 Nov 21, 2024
5e4191e
Merge branch 'bugfix/PWA-3378-login-create-account-issue-on-translate…
del15881 Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions packages/venia-ui/lib/components/AuthBar/authBar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,12 @@ const AuthBar = props => {
<span className={classes.contents}>
<AccountChip fallbackText={fallBackText} />
<span className={classes.signIn}>
<FormattedMessage
id={'authBar.signInText'}
defaultMessage={'Sign In'}
/>
<div>
<FormattedMessage
id={'authBar.signInText'}
defaultMessage={'Sign In'}
/>
</div>
</span>
</span>
</button>
Expand Down
18 changes: 12 additions & 6 deletions packages/venia-ui/lib/components/CartPage/__tests__/__snapshots__/cartPage.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,12 +165,18 @@ exports[`renders empty cart text (no adjustments, list or summary) if cart is em
<div
className="items_container"
>
<h3>
<mock-FormattedMessage
defaultMessage="There are no items in your cart."
id="cartPage.emptyCart"
/>
</h3>
<div>
<div>
<h3>
<div>
<mock-FormattedMessage
defaultMessage="There are no items in your cart."
id="cartPage.emptyCart"
/>
</div>
</h3>
</div>
</div>
</div>
<div
className="price_adjustments_container"
Expand Down
18 changes: 12 additions & 6 deletions packages/venia-ui/lib/components/CartPage/cartPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,18 @@ const CartPage = props => {
fetchCartDetails={fetchCartDetails}
/>
) : (
<h3>
<FormattedMessage
id={'cartPage.emptyCart'}
defaultMessage={'There are no items in your cart.'}
/>
</h3>
<div>
<div>
<h3>
<div>
<FormattedMessage
id={'cartPage.emptyCart'}
defaultMessage={'There are no items in your cart.'}
/>
</div>
</h3>
</div>
</div>
);

const priceAdjustments = hasItems ? (
Expand Down
28 changes: 16 additions & 12 deletions packages/venia-ui/lib/components/MiniCart/miniCart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,18 +114,22 @@ const MiniCart = React.forwardRef((props, ref) => {
className={classes.emptyMessage}
data-cy="MiniCart-emptyMessage"
>
<FormattedMessage
id={'miniCart.emptyMessage'}
defaultMessage={'There are no items in your cart.'}
/>
<span
hidden
role="status"
aria-hidden="false"
aria-live="polite"
>
{announceMiniCartCount}
</span>
<div>
<FormattedMessage
id={'miniCart.emptyMessage'}
defaultMessage={'There are no items in your cart.'}
/>
</div>
<div>
<span
hidden
role="status"
aria-hidden="false"
aria-live="polite"
>
{announceMiniCartCount}
</span>
</div>
</div>
</div>
) : (
Expand Down