Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Border decorator only works for the XL #23

Open
magicmonkey opened this issue Jun 14, 2020 · 4 comments
Open

[BUG] Border decorator only works for the XL #23

magicmonkey opened this issue Jun 14, 2020 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@magicmonkey
Copy link
Owner

Describe the bug
There's a hard-coded "96" in the border decorator code

Streamdeck version
Anything except an XL

Additional context
This needs to look at the dimensions of the incoming image, rather than looking up what streamdeck is in use.

@magicmonkey magicmonkey added the bug Something isn't working label Jun 14, 2020
@magicmonkey magicmonkey self-assigned this Jun 14, 2020
@magicmonkey
Copy link
Owner Author

There's a couple of other places as well, check for TODO comments or a hard-coded "96"

@derickr
Copy link
Contributor

derickr commented Sep 4, 2020

I've just (slightly) modified streamdeck-tricks, and the border works "just fine" on my 5x3 stream deck.

@magicmonkey
Copy link
Owner Author

Ah that's a good datapoint, thanks @derickr

@derickr
Copy link
Contributor

derickr commented Sep 5, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants