Use attributes in phpunit tests

magicsunday · Aug 2, 2024 · a73bbaf · a73bbaf
1 parent 51f9780
commit a73bbaf
Show file tree

Hide file tree

Showing 7 changed files with 55 additions and 86 deletions.
diff --git a/phpstan.neon b/phpstan.neon
@@ -14,5 +14,6 @@ parameters:
         - %currentWorkingDirectory%/test/
         - %currentWorkingDirectory%/.build/
 
-    # Ignored validations
-    checkGenericClassInNonGenericObjectType: false
+    ignoreErrors:
+        -
+            identifier: missingType.generics
diff --git a/rector.php b/rector.php
@@ -44,7 +44,7 @@
         SetList::CODING_STYLE,
         SetList::CODE_QUALITY,
         SetList::DEAD_CODE,
-        LevelSetList::UP_TO_PHP_74,
+        LevelSetList::UP_TO_PHP_81,
     ]);
 
     // Skip some rules

diff --git a/src/JsonMapper.php b/src/JsonMapper.php
@@ -302,7 +302,7 @@ private function getReflectionProperty(string $className, string $propertyName):
     {
         try {
             return new ReflectionProperty($className, $propertyName);
-        } catch (ReflectionException $exception) {
+        } catch (ReflectionException) {
             return null;
         }
     }

diff --git a/test/Annotation/ReplacePropertyTest.php b/test/Annotation/ReplacePropertyTest.php
@@ -13,6 +13,7 @@
 
 use MagicSunday\Test\Classes\ReplacePropertyTestClass;
 use MagicSunday\Test\TestCase;
+use PHPUnit\Framework\Attributes\Test;
 
 /**
  * Class ReplacePropertyTest.
@@ -25,9 +26,8 @@ class ReplacePropertyTest extends TestCase
 {
     /**
      * Tests replacing a property.
-     *
-     * @test
      */
+    #[Test]
     public function replaceProperty(): void
     {
         $result = $this->getJsonMapper()

diff --git a/test/Converter/CamelCasePropertyNameConverterTest.php b/test/Converter/CamelCasePropertyNameConverterTest.php
@@ -12,6 +12,7 @@
 namespace MagicSunday\Test\Converter;
 
 use MagicSunday\JsonMapper\Converter\CamelCasePropertyNameConverter;
+use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\TestCase;
 
 /**
@@ -25,9 +26,8 @@ class CamelCasePropertyNameConverterTest extends TestCase
 {
     /**
      * Tests mapping json properties to camel case.
-     *
-     * @test
      */
+    #[Test]
     public function checkCamelCasePropertyNameConverter(): void
     {
         $converter = new CamelCasePropertyNameConverter();