Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a credit memo generates error #233

Open
AndrewRMillar opened this issue Oct 17, 2024 · 1 comment
Open

Creating a credit memo generates error #233

AndrewRMillar opened this issue Oct 17, 2024 · 1 comment
Assignees
Labels
Fixed and planned for next release Fix will be included in the next release.
Milestone

Comments

@AndrewRMillar
Copy link

When we try to create a credit memo on the "Channable - Returns" page, the following error is generated:
"Unable to locate the order Item-ID if imported return."

image

Scenario:

  • Go to the returns page channable/returns/index/
  • Select an item
  • Via the actions choose Create Credit Memo
  • An error is shown

The error is generated in \Magmodules\Channable\Service\Returns\CreateCreditmemo::execute (link) because \Magmodules\Channable\Service\Returns\CreateCreditmemo::findOrderItemId can't find a itemId because the $item['gtin'] is not the SKU but the afas_eancode . There is no sku in the $item array so this will always result in an error.

There is a getSkuFromGtin method in the GetByOrder class but this is a private method as are the methods needed for this method.

@Frank-Magmodules
Copy link
Member

Hi @AndrewRMillar,

Thank you for providing a detailed breakdown of the issue.
We’ve implemented a fix, which will be included in the next release.

I’ll keep the issue open for now, so we can update you once the official release is available.

@Frank-Magmodules Frank-Magmodules added the Fixed and planned for next release Fix will be included in the next release. label Oct 22, 2024
@Frank-Magmodules Frank-Magmodules self-assigned this Oct 22, 2024
@Marvin-Magmodules Marvin-Magmodules added this to the v1.20.0 milestone Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed and planned for next release Fix will be included in the next release.
Projects
None yet
Development

No branches or pull requests

3 participants