Front-facing runtime API

[magne4000]

There is a third undocumented runtime parameter in Middlewares and Handlers, that contains properties native to the original adapter (like res and req for node, env for cloudflare, etc.).

Is this the best way to represent this information and make it available to users?

[brillout]

How about this?

• runtime.express.{req,res}
• runtime.hono.var
• runtime.cloudflare.env

Crystal clear and guaranteed no clash between runtimes.

[magne4000]

This seems a bit too complex.

What bothers me the most is the fact that we cannot runtime[runtime.adapter] here.
But I cannot just have runtime.adapter = 'cloudflare', because we need the distinction at several places.
Adding yet another property like runtime.key = 'cloudflare' could do the trick, but I still have the feeling that it could be simpler.

[brillout]

Maybe this?

{
  adapter: 'cloudflare-pages',
  runtime: 'workerd',
  platform: 'cloudflare',
  cloudflare: { /* ... */ }
}

[brillout]

Adding yet another property like runtime.key = 'cloudflare' could do the trick, but I still have the feeling that it could be simpler.

Some of the information is redundant (as it can be inferred) but I feel like it's okay. I guess repeating ourselves is worth it: I'd argue it's more like docs (DRY is a goal but often impractical) than internal code (that should be DRY as much as possible).

[magne4000]

I realized that the distinction between cloudflare-pages and cloudflare-worker is also necessary on the property itself ({ "cloudflare-pages": ... } instead of just { cloudflare: ... }), because the typings are not the same.
So we can keep things simpler for now, and runtime[runtime.adapter] will be valid.

[brillout]

Maybe this then:

{
  adapter: 'cloudflarePages',
  runtime: 'workerd',
  cloudflarePages: { /* ... */ }
}

Although runtime['cloudflare-pages'] is a bit unconventional I guess it's okay.