Support names in to and reply to headers #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As with "From", we should be able to specify a name part of any "To" addresses and have that appear in the delivered email.
This matches the behaviour of the Mailpace server, and the email spec, where reply-to can have multiple addresses, and each address can have a name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the behaviour of the mailpace gem to match the behaviour of the server.
The documentation indicates that names in the "To" field are supported, but currently they are stripped. The gem should not strip these.
This change also enables providing more than a single Reply-To address (with names), which the Mailpace server also currently supports (I checked!), despite the documentation implying otherwise. The prior test suggested that names in the Reply-To header would be stripped, but this is not currently true in production (I checked).