feat: add nevermore to temperature panel #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vermore value Signed-off-by: Stefan Dej <[email protected]>
Signed-off-by: Stefan Dej <[email protected]>
Signed-off-by: Stefan Dej <[email protected]>
Signed-off-by: Stefan Dej <[email protected]>
rackrick
reviewed
Aug 8, 2023
src/components/panels/Temperature/TemperaturePanelListItemNevermoreValue.vue
Outdated
Show resolved
Hide resolved
rackrick
reviewed
Aug 8, 2023
src/components/panels/Temperature/TemperaturePanelListItemNevermoreValue.vue
Outdated
Show resolved
Hide resolved
Co-authored-by: rackrick <[email protected]>
# Conflicts: # src/components/panels/Temperature/TemperaturePanelList.vue
Signed-off-by: Stefan Dej <[email protected]>
Signed-off-by: Stefan Dej <[email protected]>
Signed-off-by: Stefan Dej <[email protected]>
rackrick
approved these changes
Aug 9, 2023
This was referenced Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Dej [email protected]
Description
This is a custom implementation for the Nevermore Controller plugin. Thx @SanaaHamel for extending the Nevermore Controller Plugin for a better implementation.
Related Tickets & Documents
This PR should also solve the PR #1437
Mobile & Desktop Screenshots/Recordings
[optional] Are there any post-deployment tasks we need to perform?
none