Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep track of settings #2

Open
roelvanduijnhoven opened this issue Jul 29, 2016 · 2 comments
Open

Keep track of settings #2

roelvanduijnhoven opened this issue Jul 29, 2016 · 2 comments

Comments

@roelvanduijnhoven
Copy link

If you change the settings they are not persisted.

Maybe there is a way to store them somewhere in local storage. Although it probably isn't that easy because you are running your code on an arbitrary domain.

@maksverver
Copy link
Owner

I agree, it would be nice to be able to save settings (though currently the reading speed is the only setting), and I had considered it, but couldn't figure out how to do it.

As you noted, the bookmarklet runs in the context of the current page. Saving settings on a per-domain basis is probably not that useful.

@roelvanduijnhoven
Copy link
Author

Just aan idea. You can include the parameters in the bookmarklet. After a
changed setting you show a message asking to replace the current
bookmarklet.

Op zaterdag 30 juli 2016 heeft Maks Verver [email protected] het
volgende geschreven:

I agree, it would be nice to be able to save settings (though currently
the reading speed is the only setting), and I had considered it, but
couldn't figure out how to do it.

As you noted, the bookmarklet runs in the context of the current page.
Saving settings on a per-domain basis is probably not that useful.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAFnBih4Iku8MblCfDFjjCnJ1INao8S2ks5qa1s5gaJpZM4JYBnr
.

Groeten,
Roel van Duijnhoven

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants