Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test on macOS 13 (Intel) #3578

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Nov 6, 2024

macOS 13 is a target for homebrew, and still an important target for GHA, as it's the last Intel build they provide. I think on macOS 13 there will be a missing deduction guide error, but will have to see.

FYI, mamba-org/setup-micromamba@v2 is broken, probably see #3576.

(Likewise, I don't think GCC 11 is supported, only 13+)

Versions don't match, this is reporting Clang 17, while the homebrew job is using AppleClang 15.

@jjerphan jjerphan added the release::bug_fixes For PRs fixing bugs label Nov 18, 2024
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Copy link
Member

Thank you for this contribution, @henryiii.

Someone with a machine on macOS 13 should dive into this problem.

Note that we are only maintaining the distributions of mamba and micromamba on conda-forge, but we aren't against someone maintaining the distributions on Homebrew and upstreaming patches so that mamba and micromamba are portable or more systems.

@henryiii
Copy link
Contributor Author

Any suggestions or thoughts on #3495 ? The problem is that the GHA runs here use the latest LLVM compilers, and not the AppleClang compilers that come with macOS, and systems like homebrew use the AppleClang compilers. I think there are a couple of uses of C++ features that aren't supported by the older compilers. So far it looks pretty easily fixable, I think? Maybe just adding some explicit types instead of using the deduction guidelines.

There's also a linux issue there.

@@ -23,7 +23,7 @@ jobs:
name: Unix
strategy:
matrix:
os: [ubuntu-latest, macos-latest]
os: [ubuntu-latest, macos-latest, macos-13]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also add ubuntu-22.04 which is used by Homebrew's Linux job.

Suggested change
os: [ubuntu-latest, macos-latest, macos-13]
os: [ubuntu-latest, ubuntu-22.04, macos-latest, macos-13]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently ubuntu-latest. They tried to move to ubuntu-24.04 but had to roll it back, I think it moves Jan 2025 now.

@jjerphan
Copy link
Member

So far it looks pretty easily fixable, I think? Maybe just adding some explicit types instead of using the deduction guidelines.

Yes, definitely.

New GHA workflows can be set to test Homebrew's toolchains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release::bug_fixes For PRs fixing bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants