Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web ui: don't include result document within standalone bundle #2259

Closed
williballenthin opened this issue Aug 9, 2024 · 1 comment · Fixed by #2301
Closed

web ui: don't include result document within standalone bundle #2259

williballenthin opened this issue Aug 9, 2024 · 1 comment · Fixed by #2301
Assignees
Labels
bug Something isn't working webui related to capa results web visualization

Comments

@williballenthin
Copy link
Collaborator

please don't embed a large result document within the application bundle that is distributed to everyone:

image

the example data should be fetched on demand, perhaps by redirecting to a Capa Explorer Web URL that contains the callback query parameter pointing to an example.

otherwise, it will take a long time for this application to load for people with a slow internet connection.

Originally posted by @williballenthin in #2224 (comment)

@williballenthin williballenthin added bug Something isn't working webui related to capa results web visualization labels Aug 9, 2024
@williballenthin
Copy link
Collaborator Author

by doing the redirect, then the application should also respect browser forward/back button, which has surprpised me a couple times already.

@fariss fariss changed the title web ui: don't result document within standalone bundle web ui: don't include result document within standalone bundle Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working webui related to capa results web visualization
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants