Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize all file with a pass of pre-commit #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

neodark
Copy link
Contributor

@neodark neodark commented Oct 5, 2022

Update pre-commit-config file and run a pass of pre-commit over all files for a better code standardization.

Fixes #54

@neodark
Copy link
Contributor Author

neodark commented Oct 5, 2022

@manjurulhoque : if you don't mind could you also add this one with a hacktoberfest-accepted label please?

@manjurulhoque
Copy link
Owner

Huge changes. Need to check carefully.

@neodark
Copy link
Contributor Author

neodark commented Oct 6, 2022

The PR #53 is much smaller and fixes your issue with date and time.

This PR basically only has a better code formatting. But sure go through!

Very interesting project by the way. You have some other ones worth it too.

@neodark
Copy link
Contributor Author

neodark commented Oct 6, 2022

Another possible improvement:

I have noticed that your project only runs under python version 3.8 (I had to install your project in a conda environment that runs python 3.8). Don't forget that 3.8 is now considered outdated and there's only security support until mid-october 2014. But no more updates will be provided. You should think of switching your code base to python 3.9 or 3.10.

Of course this has nothing to do with this PR or my other one. Just a side note. (I should have added it to your issues list actually)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update pre-commit hooks
2 participants