From d4062b94bb946b8e1158034801ac1da0167618e8 Mon Sep 17 00:00:00 2001
From: Mantas <mantas783@gmail.com>
Date: Thu, 18 Apr 2024 16:50:30 +0300
Subject: [PATCH] Simplify bad file detection

---
 src/Code/Converters/BinaryFinder.php | 28 ----------------------------
 src/Code/Converters/TxtConverter.php |  2 +-
 src/Subtitles.php                    |  1 -
 3 files changed, 1 insertion(+), 30 deletions(-)
 delete mode 100644 src/Code/Converters/BinaryFinder.php

diff --git a/src/Code/Converters/BinaryFinder.php b/src/Code/Converters/BinaryFinder.php
deleted file mode 100644
index a1dd2a6..0000000
--- a/src/Code/Converters/BinaryFinder.php
+++ /dev/null
@@ -1,28 +0,0 @@
-<?php
-
-namespace Done\Subtitles\Code\Converters;
-
-use Done\Subtitles\Code\Helpers;
-use Done\Subtitles\Code\UserException;
-
-class BinaryFinder implements ConverterContract
-{
-    public function canParseFileContent($file_content)
-    {
-        if (Helpers::strContains($file_content, "\x00")) {
-            throw new UserException('This file is binary file and it is probably not a caption file.');
-        }
-
-        return false;
-    }
-
-    public function fileContentToInternalFormat($file_content, $original_file_content)
-    {
-        // no code needed
-    }
-
-    public function internalFormatToFileContent(array $internal_format , array $options)
-    {
-        // no code needed
-    }
-}
diff --git a/src/Code/Converters/TxtConverter.php b/src/Code/Converters/TxtConverter.php
index 6d47b40..78b2faf 100644
--- a/src/Code/Converters/TxtConverter.php
+++ b/src/Code/Converters/TxtConverter.php
@@ -12,7 +12,7 @@ class TxtConverter implements ConverterContract
 
     public function canParseFileContent($file_content)
     {
-        return self::hasText($file_content);
+        return self::hasText($file_content) && !Helpers::strContains($file_content, "\x00"); // not a binary file
     }
 
     public function fileContentToInternalFormat($file_content, $original_file_content)
diff --git a/src/Subtitles.php b/src/Subtitles.php
index 88fb3e0..67400cf 100644
--- a/src/Subtitles.php
+++ b/src/Subtitles.php
@@ -53,7 +53,6 @@ class Subtitles
         ['extension' => 'docx', 'format' => 'docx',             'name' => 'DOCX',                       'class' => DocxReader::class],
         ['extension' => 'rtf',  'format' => 'rtf',              'name' => 'Rich text format',           'class' => RtfReader::class], // libraryies eather throws exception, not parses, or takes long to parse 2h file
         ['extension' => 'csv',  'format' => 'csv',              'name' => 'Coma Separated Values',      'class' => CsvConverter::class], // must be last from bottom
-        ['extension' => 'bin',  'format' => 'bin',              'name' => 'Binary',                     'class' => BinaryFinder::class],
         ['extension' => 'txt',  'format' => 'txt',              'name' => 'Plaintext',                  'class' => TxtConverter::class], // must be the last one
     ];