Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors and logs in colab #19

Closed
domoritz opened this issue Jul 26, 2024 · 4 comments
Closed

Errors and logs in colab #19

domoritz opened this issue Jul 26, 2024 · 4 comments

Comments

@domoritz
Copy link
Collaborator

I tried quak in colab and it works out of the box which is amazing: https://colab.research.google.com/drive/13gA8FfYbwiOIfJLAiXOtjjLHeeLybVqT?usp=sharing. Unfortunately, I see a bunch of errors and logs below the table that are not useful for users.

Screenshot 2024-07-26 at 07 46 17
@manzt
Copy link
Owner

manzt commented Jul 26, 2024

This is good to know. I forgot that Google Colab prints logging errors directly below the output.

I also can reproduce these errors on the client when trying out the wasm example with the same data (npx vite). There appear to be some SQL syntax errors generated creating a tmp index:

DataCubeIndexer.js:132 Error: Parser Error: syntax error at or near "50000000000"
LINE 1: ...82439e AS SELECT (TIME_BUCKET(INTERVAL 50000000000 year, "date_of_birth")) AS ...
image
DataCubeIndexer.js:132 Error: Binder Error: column "weight" must appear in the GROUP BY clause or must be part of an aggregate function.
Either add it to the GROUP BY list, or use "ANY_VALUE(weight)" if the exact value of "weight" is not important.
    at U.onMessage (async_bindings.ts:150:23)
image

Not sure when I'll be able to dig deeper. Maybe a quick fix would be to suppress the errors in Colab.

@domoritz
Copy link
Collaborator Author

I think showing errors is not that big of an issue. Showing all the logs is a problem for casual users.

@manzt
Copy link
Owner

manzt commented Jul 26, 2024

ahh ok i misunderstood!

@domoritz
Copy link
Collaborator Author

Thanks or the fix. The query bugs are a separate issue imo. I added #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants