Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime styling types with IDs should conform to Identifiable #739

Open
1ec5 opened this issue Oct 6, 2021 · 0 comments
Open

Runtime styling types with IDs should conform to Identifiable #739

1ec5 opened this issue Oct 6, 2021 · 0 comments
Labels
feature 🍏 When working on a new feature or feature enhancement v11

Comments

@1ec5
Copy link
Contributor

1ec5 commented Oct 6, 2021

The Annotation, AnnotationManager, Layer, and SourceInfo protocols have the property id, which would satisfy the requirements of the Swift standard library’s Identifiable protocol. These protocols might as well explicitly conform to Identifiable as a formality.

Note that this feature request applies only to protocols that already define an id property. The Identifiable protocol also provides a default implementation for AnyObject that most likely returns the object’s memory address, something that probably would not be expected.

/ref mapbox/turf-swift#165
/cc @mapbox/maps-ios

@1ec5 1ec5 added the feature 🍏 When working on a new feature or feature enhancement label Oct 6, 2021
@macdrevx macdrevx added the v11 label Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🍏 When working on a new feature or feature enhancement v11
Projects
None yet
Development

No branches or pull requests

2 participants