Skip to content

Commit

Permalink
Fix ev charging station canonical (#161)
Browse files Browse the repository at this point in the history
- Correct EV Charging Station category SBS and search-box canonical ID
- Compare against category list from `search/searchbox/v1/list/category`
    - docs: https://docs.mapbox.com/api/search/search-box/#list-categories

1. Change the CategorySearchEngine initializer in MapboxSearchController to use SBS
2. Build and run
3. In the SearchUI tab tap the "Charging Station" category
- Result before this change: No results
- Actual result / fixed result: EV Charging Station Results are shown

- [x] Update `CHANGELOG`

Conflicts:
	CHANGELOG.md
  • Loading branch information
aokj4ck committed Apr 3, 2024
1 parent c06ac12 commit abd9abb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ Guide: https://keepachangelog.com/en/1.0.0/
- [Core] Updated to Xcode 14.1 minimum version
- [Core] Updated deployment target to iOS 12

- [Discover] Fix charging station category canonical ID

- [Core] Update SwiftLint to 0.54.0 and SwiftFormat to 0.52.11
- [Core] Fix project compliance with linter, reformat Swift files
- [Core] Add Brewfile for project
Expand Down
2 changes: 1 addition & 1 deletion Sources/MapboxSearchUI/SearchCategory.swift
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ extension SearchCategory {
/// EV Charging station category.
public static let chargingStation =
SearchCategory(
canonicalId: "ev_charging_station",
canonicalId: "charging_station",
name: Strings.Categories.chargingStation,
legacyName: "charging station",
iconName: Maki.chargingStation.xcassetName
Expand Down

0 comments on commit abd9abb

Please sign in to comment.