Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token strings undocumented #772

Open
louwers opened this issue Aug 5, 2024 · 4 comments
Open

Token strings undocumented #772

louwers opened this issue Aug 5, 2024 · 4 comments

Comments

@louwers
Copy link
Collaborator

louwers commented Aug 5, 2024

                "text-field": "{name:latin} {name:nonlatin}\n{ele} m\n▲",

I can't find anything about 'token strings' in the documentation.

Also I wonder if {name:latin} and {name:nonlatin} is MapLibre Native specific.

@louwers louwers changed the title Variables in text field undocumented? Token strings undocumented Aug 5, 2024
@HarelM
Copy link
Collaborator

HarelM commented Aug 5, 2024

Can you add a style that has this and displays something?
I believe a render test can easily check for parity in this case.

@louwers
Copy link
Collaborator Author

louwers commented Aug 6, 2024

@HarelM The :latin and :nonlatin is just part of that schema.

image

@1ec5
Copy link
Contributor

1ec5 commented Aug 10, 2024

The token string syntax is obsolete. It was removed from the style specification in mapbox/mapbox-gl-js#6216, prior to the fork. Before that, mapbox/mapbox-gl-js#5600 mapbox/mapbox-gl-native#11509 made it incompatible with expressions. As a result, mapbox-gl-language v1.0.0 dropped support for it as well, making any use of token strings an internationalization problem.

If you do document this syntax, please make sure the developer comes away with the understanding that it’s even more archaic than style functions.

/ref #188 (comment)

@HarelM
Copy link
Collaborator

HarelM commented Aug 11, 2024

We have a page about deprecations, we can include that there I guess. Feel free to open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants