Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set/map/vector equality #78

Open
marad opened this issue Sep 27, 2022 · 4 comments · Fixed by #79
Open

set/map/vector equality #78

marad opened this issue Sep 27, 2022 · 4 comments · Fixed by #79

Comments

@marad
Copy link
Owner

marad commented Sep 27, 2022

No description provided.

@marad
Copy link
Owner Author

marad commented Sep 27, 2022

Turns out I've used isIdenticalOrUndefined but that's just for identical objects.
To correctly handle different cases of equality I should implement the equal node like in JS implementation.

https://github.com/oracle/graaljs/blob/4ae2f77c22a37e116d6af13368793d19b2f4b4a0/graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/nodes/binary/JSEqualNode.java#L315

@marad
Copy link
Owner Author

marad commented Sep 27, 2022

Other example suggests otherwise https://github.com/oracle/graaljs/blob/81061dd4966bd16b42d01c1f715d3b90e313d638/graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/JSRuntime.java#L1558

@marad
Copy link
Owner Author

marad commented Sep 28, 2022 •
edited
Loading

Problems may be resolved here: oracle/graal#5090
Until this is resolved something like this is not going to work:

setOf(vectorOf(1), vectorOf(1))

Set is going to have two entries instead of one.

@marad marad linked a pull request Sep 28, 2022 that will close this issue
78 setmapvector equality #79
Merged
@marad marad closed this as completed in #79 Sep 28, 2022
@marad
Copy link
Owner Author

marad commented Sep 28, 2022

The PR meerly fixed the simple case of vectorOf(1) == vectorOf(1) but doesn't solve the issue completely.

@marad marad reopened this Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

78 setmapvector equality marad/chi-compiler-kotlin
1 participant
@marad