Fix Router.Scope implementation
#8
Comments
markuswustenberg
added a commit
that referenced
this issue
Oct 25, 2024
This adds a new `middleware` package as well as `middleware.Flags`, which allows you to supply a callback function receiving a `flag.FlagSet` to define flags on. In order to make this work, middleware is now applied before route matching. Otherwise, middleware can't change the route matching, which is necessary, because flags are part of the route before parsing. I had to disable `Router.Scope` because I can't currently make it work with the middleware changes, and I'm prioritizing the flags feature. See #8. Fixes #4
Merged
markuswustenberg
added a commit
that referenced
this issue
Oct 25, 2024
This adds a new `middleware` package as well as `middleware.Flags`, which allows you to supply a callback function receiving a `flag.FlagSet` to define flags on. In order to make this work, middleware is now applied before route matching. Otherwise, middleware can't change the route matching, which is necessary, because flags are part of the route before parsing. I had to disable `Router.Scope` because I can't currently make it work with the middleware changes, and I'm prioritizing the flags feature. See #8. Fixes #4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: