-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to StackExchange.Redis v2 #77
Comments
Right, could you point out any breaking change in the 2.0 ?
|
Nevermind, just found this https://stackexchange.github.io/StackExchange.Redis/ReleaseNotes
|
Here are the breaking changes:
https://github.com/StackExchange/StackExchange.Redis/blob/master/docs/ReleaseNotes.md
I compiled it against the new version and everything seems to work fine.
From: Marco Casamento <[email protected]>
Sent: Wednesday, September 5, 2018 4:49 PM
To: marcoCasamento/Hangfire.Redis.StackExchange <[email protected]>
Cc: Bart Coppens <[email protected]>; Author <[email protected]>
Subject: Re: [marcoCasamento/Hangfire.Redis.StackExchange] Upgrade to StackExchange.Redis v2 (#77)
Right, could you point out any breaking change in the 2.0 ?
From: Bart Coppens <[email protected]<mailto:[email protected]>>
Sent: mercoledì 5 settembre 2018 15:26
To: marcoCasamento/Hangfire.Redis.StackExchange <[email protected]<mailto:[email protected]>>
Cc: Subscribed <[email protected]<mailto:[email protected]>>
Subject: [marcoCasamento/Hangfire.Redis.StackExchange] Upgrade to StackExchange.Redis v2 (#77)
The library depends on version 1.2.6 of StackExchange.Redis
This makes it incompatible with a coebase that is upgraded to StackExchange.Redis v2.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#77> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AANtY5LWHg_EYD6d2O9KPzM80nbQRdiHks5uX9DQgaJpZM4Wa54C> . <https://github.com/notifications/beacon/AANtY2WvbYBJ7V0yauxyFzbUhnwC_eKuks5uX9DQgaJpZM4Wa54C.gif>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#77 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AO6kIkY45Bixfar0V3YbNnMqV2o4UuhKks5uX-RQgaJpZM4Wa54C>.
|
and it could be the right time to fix #73 giving that now the only version of stackexchange.redis is strong-named. |
I agree, although I don’t have much experience with best practices on how to do this for a package like this.
From: Marco Casamento <[email protected]>
Sent: Wednesday, September 5, 2018 5:27 PM
To: marcoCasamento/Hangfire.Redis.StackExchange <[email protected]>
Cc: Bart Coppens <[email protected]>; Author <[email protected]>
Subject: Re: [marcoCasamento/Hangfire.Redis.StackExchange] Upgrade to StackExchange.Redis v2 (#77)
and it could be the right time to fix #73<#73> giving that now the only version of stackexchange.redis is strong-named.
But we should also upgrade the target framework, so sticking users that can't upgrade to netstandard20 or net461 to the actual version, right ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#77 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AO6kIpU7Ka1kvLqKRSVYSbW3pogaiyaAks5uX-1YgaJpZM4Wa54C>.
|
@marcoCasamento Any timeline on when can this be released? Thanks! |
1 similar comment
@marcoCasamento Any timeline on when can this be released? Thanks! |
Any update on the new package release? I'm keen to upgrade too. |
I believe this can be closed, since #78 merged in the change and v1.8.0 in NuGet includes the change, per the release notes: https://www.nuget.org/packages/HangFire.Redis.StackExchange/1.8.0 |
The library depends on version 1.2.6 of StackExchange.Redis
This makes it incompatible with a coebase that is upgraded to StackExchange.Redis v2.
The text was updated successfully, but these errors were encountered: