-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jquery.scrollUp.js #33
base: master
Are you sure you want to change the base?
Conversation
Option to add a custom class to element
Thanks for the PR @kouratoras. Just out of curiosity, what is the reason for needing a class? |
I am building a WordPress plugin based on ScrollUp jQuery Plugin and i want to assign a class in the scroll up element, depending on the user's settings. So, just an ID is not enough for me, as i want to apply different styles. I think that class addition would be useful for situations like mine. |
Makes sense :) Would you be able to compile the distribution files? Check out the CONTRIBUTE.md file. If you can't compile, I'll merge it in over the weekend. |
It's the first time i use gulp. I just change the src/jquery.scrollUp.js file and run gulp to complile? I does not change dist files.. |
Are there any errors? I'll close this PR and add it in. Will create some better contribution docs too :) |
No error, just no modified output files. |
Hi! Did you close the PR? |
I've not merged it in as I've not had chance to check everything out and build out the files yet. I'll look into this hopefully tonight :) |
Option to add a custom class to element