Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onTopHandler functionality. #46

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add onTopHandler functionality. #46

wants to merge 2 commits into from

Conversation

SMHFandA
Copy link

It is very usefull functionality, i think. If page compleatly scrolling up then call function. I implement this feature, but i'm not strong JavaScript programmer. Maybe you could implement this feature better. Sorry for my english.

@markgoodyear
Copy link
Owner

I like this idea. I think we can add in more callbacks, such as onBottom too. Would you be happy to add that to your PR?

Also would you be able to amend the code style so it fits in the rest of the styles (e.g. spacing around before the curly bracket, and use strict equality ===). Adding some info to the readme, and also run gulp to generate the dist files would be great too :).

@SMHFandA
Copy link
Author

SMHFandA commented Nov 8, 2015

I'll done. Also i'm added demo section. See how look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants