Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow items to be numeric #42

Open
markhwhiteii opened this issue Jul 3, 2021 · 0 comments
Open

allow items to be numeric #42

markhwhiteii opened this issue Jul 3, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@markhwhiteii
Copy link
Owner

see the error found in #41 when trying to run eloscoring() on data where the items have numeric IDs instead of character names. a few thoughts:

  • this should be limited to just eloscoring—but double-check elsewhere
  • I think a simple way to do this would be just to coerce the column to character before running?
  • need to implement a unit test for items coming in of different classes
@markhwhiteii markhwhiteii added the bug Something isn't working label Jul 3, 2021
@markhwhiteii markhwhiteii self-assigned this Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant