Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest type checking tool and configuration, and maybe add to tox? #113

Open
handrews opened this issue Jul 25, 2023 · 0 comments
Open

Comments

@handrews
Copy link
Contributor

I decided to try to run mypy because I keep forgetting / messing up type annotations, and it returned 519 errors in the package code and 8 in the tests. Looking at the errors a lot of them are clearly over-zealous attempts to make Python into Java or C#. For example, it gets very confused by the mix of JSON and JSONSchema objects in a JSON Schema document and can't work out that evaluate() is only called on JSONSchema instances.

I am assuming that either there is a specific configuration or a different tool intended for use? I'd be happy to add something to the tox configuration if there is a type checking setup that is expected to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant