Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spouses method is not considering the current spouse #20

Open
mukeshsinghr opened this issue Aug 18, 2018 · 1 comment
Open

spouses method is not considering the current spouse #20

mukeshsinghr opened this issue Aug 18, 2018 · 1 comment

Comments

@mukeshsinghr
Copy link

Currently spouses method is just checking if there is any children with the spouse or not. In case no children then its omitting the spouse.

Say for eg.
User has added current spouse but has no children yet. When he checks spouses method it returns no result. If user checks using current_spouse method then it shows a result.

I believe we should consider current_spouse as well for spouses.

Ref: https://github.com/masciugo/genealogy/blob/master/lib/genealogy/query_methods.rb#L63

@masciugo
Copy link
Owner

I'll add that in the next release. thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants