Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grapher zoom out bugfix #349

Merged
merged 3 commits into from
Nov 12, 2024

Commits on Nov 11, 2024

  1. Configuration menu
    Copy the full SHA
    d3a2690 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Initialize the grapher windows with full graph context and non-connec…

    …ted mode
    
    * Reasoning: It is difficult to judge, what is the most often used combination of settings and thus, which should be the default settings for the grapher. For the case of analysing single tracks the item source "track of selection" makes most sense. Also in this case drawing the edges in the grapher between these points makes sense. In other cases, such when inspecting large selections or even the dataset as a whole, showing the edges does not really help and leads to a very confusing plot. For the case of inspecting the full dataset without any selection the setting "track of selection", leads to an empty plot, when the grapher is first show. Thus, with this commit, the defaults are changed to full graph context and non-connected.
    stefanhahmann committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    0dbf523 View commit details
    Browse the repository at this point in the history
  2. Wait with fully zooming out until a first layout() was finished, when…

    … graph changed was called
    
    * Reasoning: before, there was fixed timeout. However, with large datasets, it could have happened that graphchanged() + layout() was not completey performed before zoom out was started leading to unexpected behaviour. This commit introduces a process that lets the zooming out wait until the graph was layouted once according to the current data.
    stefanhahmann committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    e3c6a58 View commit details
    Browse the repository at this point in the history