-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
calendar solution #3986
base: master
Are you sure you want to change the base?
calendar solution #3986
Conversation
Igor-Pysak
commented
Dec 2, 2024
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on setting up the calendar with SCSS and BEM methodology! 🎉 Your code meets the task requirements and constraints effectively. The variables $week-days
, $day-size
, and $gap-size
are correctly defined in the variables.scss
file, ensuring everything works as expected. Keep up the excellent work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
} | ||
|
||
.calendar { | ||
width: calc($day-size * 7 + $gap-size * 6); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $day-size
is used but not defined in this file. Ensure it is defined or imported from another SCSS file.
display: flex; | ||
flex-wrap: wrap; | ||
column-count: 7; | ||
gap: $gap-size; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $gap-size
is used but not defined in this file. Ensure it is defined or imported from another SCSS file.
} | ||
} | ||
|
||
@each $day, $day-position in $week-days { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $week-days
is used but not defined in this file. Ensure it is defined or imported from another SCSS file.