Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #703

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Develop #703

wants to merge 5 commits into from

Conversation

stas-dukach
Copy link

VinnieJ-2k20
VinnieJ-2k20 suggested changes Mar 23, 2021
View reviewed changes
Copy link

@VinnieJ-2k20 VinnieJ-2k20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there.
Need to change approach to styling the document.

src/style.css Outdated
Comment on lines 6 to 20
h1 {
font-size: 17px;
font-weight: bold;
margin: 0;
}

h2 {
font-size: 15px;
margin: 1em 0;
font-weight: normal;
}

p {
margin: 0;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't style using tags, add classes.

VinnieJ-2k20
VinnieJ-2k20 approved these changes Mar 23, 2021
View reviewed changes
Copy link

@VinnieJ-2k20 VinnieJ-2k20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinnieJ-2k20 VinnieJ-2k20 VinnieJ-2k20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stas-dukach @VinnieJ-2k20