Complite #1464
Complite #1464
Conversation
There was a problem hiding this comment.
Great job on implementing the caching decorator! 🎉 While there are minor issues with the type hints, they don't affect the functionality of your code. Consider updating the type hints for better clarity and flexibility in the future. Keep up the great work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| pass | ||
| storage_cache = {} | ||
|
|
||
| def wrapper(*args: int) -> int: |
There was a problem hiding this comment.
The type hint *args: int is incorrect. *args can accept any number of arguments of any type, not just integers. You should use *args: Any or omit the type hint for *args to allow for more flexibility.
| pass | ||
| storage_cache = {} | ||
|
|
||
| def wrapper(*args: int) -> int: |
There was a problem hiding this comment.
The return type hint -> int for the wrapper function is incorrect. Since the wrapper function returns the result of func(*args), its return type should match the return type of func. Consider using -> Any or the return type of func if known.
No description provided.