Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SymmetryData for structures is missing a few pydantic field descriptions #734

Open
Andrew-S-Rosen opened this issue May 19, 2023 · 0 comments

Comments

@Andrew-S-Rosen
Copy link
Member

Andrew-S-Rosen commented May 19, 2023

The returned entries are:

symmetry.update(
{
"source": "spglib",
"symbol": sg.get_space_group_symbol(),
"number": sg.get_space_group_number(),
"point_group": sg.get_point_group_symbol(),
"crystal_system": CrystalSystem(sg.get_crystal_system().title()),
"hall": sg.get_hall(),
"version": spglib.__version__,
}
)

However, I don't think source, hall, or version have an associated pydantic field description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant