Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Literal type hints for CrystalSystem #989

Closed
wants to merge 2 commits into from
Closed

Use Literal type hints for CrystalSystem #989

wants to merge 2 commits into from

Conversation

Andrew-S-Rosen
Copy link
Member

@Andrew-S-Rosen Andrew-S-Rosen commented Apr 12, 2024 •
edited
Loading

Switch from using a ValueEnum approach for CrystalSystem to Literal strings. Closes #914.

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • task 1
    • task 2
  • I have run the tests locally and they passed.
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

@Andrew-S-Rosen Andrew-S-Rosen changed the title WIP Use Literal type hints for CrystalSystem Apr 12, 2024
@Andrew-S-Rosen Andrew-S-Rosen marked this pull request as draft April 12, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: The .as_dict() method on CrystalSystem is not Monty compatible
1 participant
@Andrew-S-Rosen