You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks to clever synatx highlighting in my code editor, I noticed that the kwargs sort, skip, and limit that are shown for MongoStore.groupby and MemoryStore.groupby appear to be non-functional.
These kwargs should be made functional (preferably, if it makes sense) or removed.
Related - it is not clear to me why the groupby methods for MongoStore and MemoryStore need to be different, since MemoryStore is designed to emulate MongoStore in every respect. If MemoryStore could inherit MongoStore's groupby that would be more robust (and prevent subtle bugs like the one described in #621 ).
Related #2 - MemoryStore.groupby does not return any data unless you explicitly pass fields to properties. This may affect other MongoLike stores, too but I'm not sure. See discussion here.
I may investigate this at a later time but would welcome comments from better-informed developers!
The text was updated successfully, but these errors were encountered:
rkingsbury
changed the title
MongoLike groupby ignore sort, skip, limit kwargs
MongoLike groupby ignore sort, skip, limit kwargs; confusing properties behavior
May 27, 2022
Thanks to clever synatx highlighting in my code editor, I noticed that the kwargs
sort
,skip
, andlimit
that are shown forMongoStore.groupby
andMemoryStore.groupby
appear to be non-functional.These kwargs should be made functional (preferably, if it makes sense) or removed.
Related - it is not clear to me why the
groupby
methods forMongoStore
andMemoryStore
need to be different, sinceMemoryStore
is designed to emulateMongoStore
in every respect. IfMemoryStore
could inheritMongoStore
'sgroupby
that would be more robust (and prevent subtle bugs like the one described in #621 ).Related #2 -
MemoryStore.groupby
does not return any data unless you explicitly pass fields toproperties
. This may affect other MongoLike stores, too but I'm not sure. See discussion here.I may investigate this at a later time but would welcome comments from better-informed developers!
The text was updated successfully, but these errors were encountered: