Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Enable terminate_on_match for Outcar parser #4041

Open
DanielYang59 opened this issue Sep 5, 2024 · 1 comment
Open

[Enhancement] Enable terminate_on_match for Outcar parser #4041

DanielYang59 opened this issue Sep 5, 2024 · 1 comment

Comments

@DanielYang59
Copy link
Contributor

DanielYang59 commented Sep 5, 2024

Re-post from #4034 (comment), need investigation of implications of turning on terminate_on_match of read_pattern for io.vasp.outputs.Outcar parser (at least for those "global" tags that is consistent across the entire run). Sounds like this would speed up initialization by early exit upon hit.

@DanielYang59
Copy link
Contributor Author

DanielYang59 commented Nov 25, 2024

Another related proposal, perhaps we should consider:

  • Write a lazy version of read_pattern, to get a collection of all patterns and walk through the file once
    AND/OR
  • State machine
  • Refactor read_pattern to process in memory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant