Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same routines to install Mathesar in testing as in production #3258

Open
dmos62 opened this issue Oct 25, 2023 · 0 comments
Open

Use same routines to install Mathesar in testing as in production #3258

dmos62 opened this issue Oct 25, 2023 · 0 comments
Labels
affects: technical debt Improves the state of the codebase ready Ready for implementation type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL
Milestone

Comments

@dmos62
Copy link
Contributor

dmos62 commented Oct 25, 2023

Both in production and in testing we have separate routines for installing Mathesar schemata. The fact that we use different routines in backend and in frontend is a problem, because that implies smaller test coverage. I ran into an annoying bug that only showed up in the CI, but not when testing locally, because of this: the bug was in the production Mathesar install routines and that was being called when setting up the CI container, but not when running tests locally. We want tests to be as similar to production as possible.

As of time of writing, the routine used in production is db.install.install_mathesar. Fixtures in charge of this in testing are in conftest.py.

@dmos62 dmos62 added affects: technical debt Improves the state of the codebase ready Ready for implementation type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL labels Oct 25, 2023
@seancolsen seancolsen added this to the Backlog milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: technical debt Improves the state of the codebase ready Ready for implementation type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL
Projects
No open projects
Development

No branches or pull requests

2 participants