Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for DB creation/editing/deletion via API #3259

Closed
dmos62 opened this issue Oct 25, 2023 · 4 comments
Closed

Add tests for DB creation/editing/deletion via API #3259

dmos62 opened this issue Oct 25, 2023 · 4 comments
Labels
ready Ready for implementation type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL
Milestone
Backlog

Comments

@dmos62
Copy link
Contributor

dmos62 commented Oct 25, 2023

Test coverage for adding/removing/editing DBs via the API is insufficient. I didn't search our test suite for relevant tests (there might be some), but I was able to break basic database creation (via the API) without having any test fail.
@dmos62 dmos62 added ready Ready for implementation type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL labels Oct 25, 2023
@FidalMathew
Copy link
Contributor

Hi @dmos62. I want to work on it, could you guide me on how to proceed with this issue?

@Shraeyas
Copy link
Contributor

@dmos62 Can you please give some details on how to reproduce this?

@dmos62
Copy link
Contributor Author

dmos62 commented Oct 27, 2023

@Shraeyas you'd have to figure out which endpoints do these things and what tests are missing for them.

@seancolsen seancolsen added this to the Backlog milestone Nov 2, 2023
@seancolsen
Copy link
Contributor

I'm closing this ticket because this API is be ripped out and completely replaced, as specified in #3291

@kgodey kgodey closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ready Ready for implementation type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL
Projects
No open projects
[NO LONGER USED] Mathesar work tracker
Status: Done
Milestone
Backlog
Development

No branches or pull requests
5 participants
@seancolsen @kgodey @dmos62 @Shraeyas @FidalMathew