Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record page widget causing overflow #3289

Closed
seancolsen opened this issue Nov 2, 2023 · 5 comments · Fixed by #3303
Closed

Record page widget causing overflow #3289

seancolsen opened this issue Nov 2, 2023 · 5 comments · Fixed by #3303
Labels
help wanted Community contributors can implement this ready Ready for implementation regression type: bug Something isn't working work: frontend Related to frontend code in the mathesar_ui directory
Milestone

Comments

@seancolsen
Copy link
Contributor

Reproduce

  1. Go to a record page that contains a table widget.
  2. Resize columns within the widget in order to make the total width of all columns wider than the viewport.
  3. Expect to see a horizontal scroll bar which allows the sheet to be scrolled.
  4. Expect the content of the record fields at the top of the page to be unaffected by the width of the widget columns.
  5. Instead, observe that wide columns in the widget push the content of the whole page out, causing horizontal scrolling for the records fields at the top of the page, too.
2023-11-02_09-07-05.mp4

I'm fairly certain that this is a regression, because I vaguely recall ensuring that this bug did not exist when I implemented that table widget within the record page. However I could be mistaken.

@seancolsen seancolsen added help wanted Community contributors can implement this regression restricted: maintainers Only maintainers can resolve this issue ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory labels Nov 2, 2023
@seancolsen seancolsen added this to the High priority milestone Nov 2, 2023
@seancolsen seancolsen added type: bug Something isn't working and removed type: enhancement New feature or request restricted: maintainers Only maintainers can resolve this issue labels Nov 2, 2023
@Mayank77maruti
Copy link

Hey @seancolsen , please do assign this task to me .

@seancolsen
Copy link
Contributor Author

@Mayank77maruti you're welcome to work on this and submit a PR, but in general we don't assign tickets to new contributors, as noted in our Contributor Guide. Once we've already merged a PR of yours, then we'll be happy to assign tickets to you after that. The reason for this policy is that in the past it has been a maintenance burden for us to manage ticket assignments while having an overwhelming volume of people fail to submit their first PR when initially expressing intent to contribute.

@kanugurajesh
Copy link

I'd like to work on this issue.

@kanugurajesh
Copy link

is the issue the below one. Do you want me to remove the scrollbar. can you please write a reply so that I can work on it

mathesar-overflow-confirmation.mp4

@seancolsen
Copy link
Contributor Author

seancolsen commented Nov 7, 2023

@Rajesh604 your video above is irrelevant to this ticket. Your video depects the Import page. This ticket pertains to the Record page.

You'll need to view a record page that has related records. You can load the all_types table and navigate to the first record in the table, titled "Lorem". Then you should see this:

image

See how that white section at the top of the page is off-center? It should be centered. That misalignment is indicative of the problem that this ticket describes.

Separately, I noticed you made a comment in another ticket, calling my attention to this ticket. Please do not do that. It creates unnecessary notifications and does not properly organize communication into cohesive topics. In general, commenting on one ticket should be sufficient to get a person's attention about that topic. If you've been waiting for a reply for a long time, then it may be appropriate to follow up, either with a comment on that same thread (not an unrelated ticket), or a comment in Matrix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Community contributors can implement this ready Ready for implementation regression type: bug Something isn't working work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants